feat(status): report skipped status for unmatched PipelineRuns by zakisk · Pull Request #2918 · tektoncd/pipelines-as-code

zakisk · 2026-08-11T06:50:08Z

📝 Description of the Change

When a repository has multiple PipelineRuns in .tekton/ targeting different events, only the ones matching the incoming event run. The rest are silently ignored, leaving gaps in the Git provider's status checks UI.

For example, a repository with two PipelineRuns:

.tekton/build.yaml — on-event: pull_request, on-target-branch: main
.tekton/deploy.yaml — on-event: push, on-target-branch: main

When a pull request is opened, build.yaml matches and runs. Without this feature, deploy.yaml produces no status at all — it is impossible to tell from the PR whether it was skipped intentionally or never picked up. With status_checks enabled:

spec:
settings:
status_checks:
enabled: true
mode: "per_pipelinerun"

Pipelines-as-Code now reports a "skipped" status for deploy.yaml on the pull request, making the full picture visible in the provider UI.

The matcher now returns both matched and unmatched PipelineRuns. After the matched runs complete, the controller iterates the unmatched list and calls CreateStatus on each with the configured conclusion. The conclusion defaults to skipped but can be set to success or neutral via the unmatched_conclusion field.

Every provider maps that conclusion to its native state:

GitHub App: check run conclusion "skipped"
GitHub Webhook: commit status "success" (API has no skipped)
GitLab: pipeline status "skipped"
Bitbucket Cloud: build status "STOPPED"
Bitbucket Data Center: build status "UNKNOWN"
Gitea/Forgejo: commit status "success" (no skipped state)

The setting is inheritable from the global Repository CR via the existing Settings.Merge path.

The whole feature is behind an opt-in flag (enabled: false by default) and marked as tech preview in the documentation.

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

I have not used any AI assistance for this PR.
I have used AI assistance for this PR. (For testing)

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

codecov · 2026-08-11T06:52:25Z

Codecov Report

❌ Patch coverage is 79.46429% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.91%. Comparing base (458ef97) to head (f6328b9).

Files with missing lines	Patch %	Lines
pkg/pipelineascode/match.go	61.76%	13 Missing ⚠️
pkg/matcher/annotation_matcher.go	81.81%	4 Missing ⚠️
pkg/provider/gitea/gitea.go	50.00%	3 Missing ⚠️
pkg/provider/github/status.go	77.77%	2 Missing ⚠️
pkg/provider/gitlab/gitlab.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2918      +/-   ##
==========================================
+ Coverage   85.61%   85.91%   +0.30%     
==========================================
  Files         164      164              
  Lines       12516    12574      +58     
==========================================
+ Hits        10715    10803      +88     
+ Misses       1800     1770      -30     
  Partials        1        1

Flag	Coverage Δ
unit-tests	`85.91% <79.46%> (+0.30%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pipelines-as-code · 2026-08-11T06:55:18Z

Paco Review ⚠️

Paco: the model returned output that could not be parsed as a review.

_{Reviewed commit: 875837e}

pipelines-as-code

Paco inline comments -- see the Paco Review summary comment for the overview.

zakisk · 2026-08-12T12:40:13Z

/paco review

zakisk · 2026-08-12T12:40:31Z

I can't request review from copilot. cc: @chmouel

pipelines-as-code

Paco inline comments -- see the Paco Review summary comment for the overview.

Copilot

Pull request overview

Adds an opt-in “status_check” feature to report provider statuses for PipelineRuns that do not match the incoming event, improving visibility in Git provider UIs when multiple .tekton/ PipelineRuns target different triggers.

Changes:

Extend PipelineRun matching to return both matched and unmatched PipelineRuns, and (when enabled) report a “skipped/success/neutral” status for each unmatched PipelineRun.
Update provider-specific status mapping/formatting to support a “skipped” conclusion (or best-effort equivalents where unsupported).
Add unit/E2E test coverage and documentation/CRD updates for the new Repository spec.settings.status_check API.

Reviewed changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/pkg/bitbucketdatacenter/crd.go	Pass Settings into Bitbucket DC E2E Repository CR creation.
test/pkg/bitbucketcloud/crd.go	Pass Settings into Bitbucket Cloud E2E Repository CR creation.
test/gitlab_merge_request_test.go	Add E2E coverage for skipped status reporting on GitLab MR.
test/github_pullrequest_test.go	Add E2E coverage for skipped status reporting (GitHub App + webhook).
test/gitea_pull_request_test.go	Add E2E coverage for skipped status reporting on Gitea/Forgejo.
test/bitbucket_datacenter_push_test.go	Update CreateCRD call signature to include opts/settings.
test/bitbucket_datacenter_pull_request_test.go	Add Bitbucket DC PR E2E coverage for skipped statuses + CreateCRD signature update.
test/bitbucket_datacenter_dynamic_variables_test.go	Update CreateCRD call signature to include opts/settings.
test/bitbucket_cloud_pullrequest_test.go	Add Bitbucket Cloud PR E2E coverage for skipped statuses.
pkg/provider/github/status.go	Map skipped conclusion appropriately for check runs and commit statuses; avoid empty DetailsURL in check run creation.
pkg/provider/github/status_test.go	Add unit coverage for skipped conclusion behavior (apps + webhook).
pkg/provider/gitea/status_test.go	Add unit coverage for skipped conclusion mapping (success + “Skipped” description).
pkg/provider/gitea/gitea.go	Add skipped conclusion formatting + map skipped to success for commit statuses.
pkg/provider/bitbucketdatacenter/bitbucketdatacenter.go	Map skipped conclusion to Bitbucket DC “UNKNOWN” state and update title text.
pkg/provider/bitbucketdatacenter/bitbucketdatacenter_test.go	Add unit coverage for skipped conclusion.
pkg/provider/bitbucketcloud/bitbucket.go	Update skipped title text for Bitbucket Cloud status reporting.
pkg/provider/bitbucketcloud/bitbucket_test.go	Add unit coverage for skipped conclusion.
pkg/pipelineascode/testdata/no-match/.tekton/nomatch.yaml	Add annotations to ensure deterministic “no-match” behavior for tests.
pkg/pipelineascode/pipelineascode.go	Report per-unmatched statuses (when enabled) after starting matched PipelineRuns; add helper reporter.
pkg/pipelineascode/pipelineascode_test.go	Add Run() test covering per-unmatched status reporting.
pkg/pipelineascode/pipelineascode_statuscheck_test.go	New unit tests for status reporting helper behavior and error emission.
pkg/pipelineascode/match.go	Plumb unmatched PipelineRuns through the matching flow.
pkg/pipelineascode/match_test.go	Update tests to validate unmatched PipelineRuns counts.
pkg/matcher/annotation_matcher.go	Return unmatched PipelineRuns alongside matches and populate unmatched list on non-match branches.
pkg/matcher/annotation_matcher_test.go	Add tests verifying unmatched PipelineRun tracking and related logs.
pkg/apis/pipelinesascode/v1alpha1/zz_generated.deepcopy.go	Regenerate deep-copies to include StatusCheck.
pkg/apis/pipelinesascode/v1alpha1/types.go	Add StatusCheck API types/constants and inheritance via Settings.Merge.
pkg/apis/pipelinesascode/v1alpha1/types_test.go	Add tests verifying StatusCheck inheritance/precedence.
docs/content/docs/operations/global-repository-settings.md	Link global settings doc to the new Status Check guide.
docs/content/docs/guides/statuses.md	Document the unmatched-PipelineRun status-check feature at a high level.
docs/content/docs/guides/repository-crd/status-check.md	New tech preview guide documenting configuration and provider behavior.
docs/content/docs/guides/_index.md	Update guide index card subtitle to mention status checks.
docs/content/docs/api/settings.md	Add API reference documentation for `settings.status_check`.
docs/content/docs/api/repository.md	Include `status_check` snippet in Repository API docs.
docs/content/docs/api/repository-spec.md	Include `status_check` snippet in RepositorySpec API docs.
config/300-repositories.yaml	CRD schema updates for the new `spec.settings.status_check` fields.

Files not reviewed (1)

pkg/apis/pipelinesascode/v1alpha1/zz_generated.deepcopy.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

zakisk · 2026-08-14T06:06:33Z

/retest

zakisk · 2026-08-20T11:29:51Z

/retest

zakisk · 2026-08-21T07:15:14Z

/retest

zakisk · 2026-08-25T10:37:14Z

/retest

zakisk · 2026-08-26T07:12:39Z

/test go-testing

theakshaypant · 2026-09-07T05:44:29Z

+					if event.EventType == triggertype.PullRequestLabeled.String() {
+						unmatchedPRs = append(unmatchedPRs, prun)


This contradicts with the description ... produces no status at all — it is impossible to tell from the PR whether it was skipped intentionally or never picked up. The on-label pipelinerun shows no status on pull request and it seems similar to the scenario described in the description.

theakshaypant · 2026-09-07T15:00:22Z

 	}

-	matchedPRs, err = matcher.MatchPipelinerunByAnnotation(ctx, p.logger, pipelineRuns, p.run, p.event, p.vcx, p.eventEmitter, repo, false)
+	// unmatchedPRs are filtered out above if RemoteTasks is enabled so we should also check if RemoteTasks is enabled then


[question] What happens when there is an error in resolving a pipelinerun? Is it reported as skipped or is there an error reported for the prun?

No, there will be no status check reporting if any error

theakshaypant

@zakisk Will do a final review after rebase.

zakisk · 2026-09-09T06:20:33Z

resolved the merge conflict and changed the PR description and commit message as per new changes in field names

theakshaypant

Please verify if the operator precedence would not break the logic in the provider.
Said places have been highlighted with suggestions.

zakisk · 2026-09-09T13:58:04Z

pac pipelineruns are not triggering 😕

zakisk · 2026-09-10T05:16:45Z

/test

theakshaypant

My AI is flagging the unmatches prun filtering logic as fragile

Issue: The isAlreadyAddedInUnmatched flag prevents duplicate entries but uses inconsistent logic - set only in on-comment case but comments suggest awareness it works through continue statements
Impact: Low risk due to control flow, but fragile for future maintenance
Fix: Simplify by explicitly setting flag or use a map to track additions

theakshaypant

Having said that, I have gone through the changes manually and have raised the issues I could find and the updates look fine to me.
All comments have been addressed, CI is green. e2e tests added to verify the changes.
LGTM.

zakisk · 2026-09-10T11:34:49Z

Fix: Simplify by explicitly setting flag or use a map to track additions

if I do assign it everywhere then golangci-lint won't be happy and complain about inaffectualassign

zakisk · 2026-09-10T12:13:00Z

@chmouel anything from you?

zakisk · 2026-09-10T16:22:51Z

Low risk due to control flow, but fragile for future maintenance

@theakshaypant this makes sense so I switched to map which seems idiomatic... PTAL

When a repository has multiple PipelineRuns in .tekton/ targeting different events, only the ones matching the incoming event run. The rest are silently ignored, leaving gaps in the Git provider's status checks UI. For example, a repository with two PipelineRuns: .tekton/build.yaml — on-event: pull_request, on-target-branch: main .tekton/deploy.yaml — on-event: push, on-target-branch: main When a pull request is opened, build.yaml matches and runs. Without this feature, deploy.yaml produces no status at all — it is impossible to tell from the PR whether it was skipped intentionally or never picked up. With status_checks enabled: spec: settings: status_checks: enabled: true mode: "per_pipelinerun" Pipelines-as-Code now reports a "skipped" status for deploy.yaml on the pull request, making the full picture visible in the provider UI. The matcher now returns both matched and unmatched PipelineRuns. After the matched runs complete, the controller iterates the unmatched list and calls CreateStatus on each with the configured conclusion. The conclusion defaults to `skipped` but can be set to `success` or `neutral` via the `unmatched_conclusion` field. Every provider maps that conclusion to its native state: - GitHub App: check run conclusion "skipped" - GitHub Webhook: commit status "success" (API has no skipped) - GitLab: pipeline status "skipped" - Bitbucket Cloud: build status "STOPPED" - Bitbucket Data Center: build status "UNKNOWN" - Gitea/Forgejo: commit status "success" (no skipped state) The setting is inheritable from the global Repository CR via the existing Settings.Merge path. The whole feature is behind an opt-in flag (enabled: false by default) and marked as tech preview in the documentation. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>

zakisk requested a review from chmouel August 11, 2026 06:51

chmouel reviewed Aug 11, 2026

View reviewed changes

Comment thread docs/content/docs/guides/repository-crd/status-check.md Outdated

pipelines-as-code Bot added the paco/review-hard Paco review difficulty label Aug 11, 2026

pipelines-as-code Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread pkg/pipelineascode/match.go Outdated

Comment thread pkg/matcher/annotation_matcher.go

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from 08fde7b to e2008a9 Compare August 12, 2026 09:59

pipelines-as-code Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread pkg/pipelineascode/pipelineascode.go Outdated

Comment thread pkg/pipelineascode/pipelineascode.go Outdated

chmouel requested a lite review from Copilot August 12, 2026 12:47

Copilot started reviewing on behalf of chmouel August 12, 2026 12:51 View session

Copilot AI reviewed Aug 12, 2026

View reviewed changes

Comment thread pkg/pipelineascode/pipelineascode.go Outdated

Comment thread pkg/apis/pipelinesascode/v1alpha1/types.go Outdated

Comment thread pkg/pipelineascode/match.go Outdated

Comment thread pkg/pipelineascode/pipelineascode.go Outdated

chmouel reviewed Aug 12, 2026

View reviewed changes

Comment thread pkg/matcher/annotation_matcher.go Outdated

Comment thread pkg/pipelineascode/pipelineascode.go Outdated

chmouel reviewed Aug 12, 2026

View reviewed changes

Comment thread pkg/pipelineascode/pipelineascode.go

Comment thread pkg/apis/pipelinesascode/v1alpha1/types.go Outdated

tekton-robot added the needs-rebase label Aug 12, 2026

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from e2008a9 to 1d55e09 Compare August 13, 2026 10:48

tekton-robot removed the needs-rebase label Aug 13, 2026

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from 1d55e09 to 79b4ba9 Compare August 13, 2026 17:09

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch 3 times, most recently from bd2762c to d7a4b71 Compare August 19, 2026 12:43

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from d7a4b71 to 8805b0f Compare August 20, 2026 14:40

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch 2 times, most recently from d01f965 to 043ba0e Compare August 25, 2026 06:16

theakshaypant reviewed Sep 7, 2026

View reviewed changes

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch 2 times, most recently from 6844f34 to d2b2ce2 Compare September 7, 2026 13:05

theakshaypant reviewed Sep 7, 2026

View reviewed changes

theakshaypant reviewed Sep 8, 2026

View reviewed changes

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch 3 times, most recently from 48b345c to 534e9b7 Compare September 8, 2026 12:56

tekton-robot added the needs-rebase label Sep 8, 2026

theakshaypant reviewed Sep 9, 2026

View reviewed changes

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from 534e9b7 to cd29abd Compare September 9, 2026 05:14

tekton-robot removed the needs-rebase label Sep 9, 2026

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from cd29abd to 6f86766 Compare September 9, 2026 06:18

theakshaypant reviewed Sep 9, 2026

View reviewed changes

Comment thread pkg/matcher/annotation_matcher.go Outdated

Comment thread pkg/matcher/annotation_matcher.go Outdated

Comment thread pkg/apis/pipelinesascode/v1alpha1/zz_generated.deepcopy.go

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from 6f86766 to 6328de4 Compare September 9, 2026 06:56

theakshaypant reviewed Sep 9, 2026

View reviewed changes

Comment thread pkg/matcher/annotation_matcher.go Outdated

Comment thread pkg/provider/gitea/gitea.go Outdated

Comment thread pkg/provider/gitlab/gitlab.go Outdated

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from 6328de4 to b1e536c Compare September 9, 2026 13:55

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from b1e536c to 4758a63 Compare September 10, 2026 09:50

theakshaypant reviewed Sep 10, 2026

View reviewed changes

theakshaypant approved these changes Sep 10, 2026

View reviewed changes

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from 4758a63 to 9e1d38e Compare September 10, 2026 16:22

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from 9e1d38e to c024dc7 Compare September 10, 2026 16:26

zakisk force-pushed the SRVKP-13160-skipped-check-run-per-pipelinerun-mode-imple branch from c024dc7 to f6328b9 Compare September 11, 2026 06:30

		if event.EventType == triggertype.PullRequestLabeled.String() {
		unmatchedPRs = append(unmatchedPRs, prun)

Uh oh!

Conversation

zakisk commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description of the Change

🔗 Linked GitHub Issue

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

codecov Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

pipelines-as-code Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Paco Review ⚠️

Uh oh!

pipelines-as-code Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zakisk commented Aug 12, 2026

Uh oh!

zakisk commented Aug 12, 2026

Uh oh!

pipelines-as-code Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zakisk commented Aug 14, 2026

Uh oh!

zakisk commented Aug 20, 2026

Uh oh!

zakisk commented Aug 21, 2026

Uh oh!

zakisk commented Aug 25, 2026

Uh oh!

zakisk commented Aug 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theakshaypant Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

theakshaypant Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

zakisk Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theakshaypant left a comment

Choose a reason for hiding this comment

Uh oh!

zakisk commented Sep 9, 2026

zakisk commented Aug 11, 2026 •

edited

Loading

codecov Bot commented Aug 11, 2026 •

edited

Loading

pipelines-as-code Bot commented Aug 11, 2026 •

edited

Loading